Use the current fragment's notes when showNotes: true#3491
Open
sachac wants to merge 2 commits intohakimel:masterfrom
Open
Use the current fragment's notes when showNotes: true#3491sachac wants to merge 2 commits intohakimel:masterfrom
sachac wants to merge 2 commits intohakimel:masterfrom
Conversation
* js/controllers/notes.js: Use only the current fragment's notes if showing a fragment. * js/reveal.js: Update notes whenever fragments are shown or hidden. Related to: - hakimel@f496613 - hakimel#1636
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for making and sharing reveal.js! I'm new to how reveal.js works, so the event listeners for updating the fragments/notes are probably in the wrong place, but I thought I'd send this little tweak upstream just in case it helps. This makes the sidebar speaker notes shown with "showNotes: true" step through the notes in fragments. Hope it's useful!
Related to: